| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, rekgrpth(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18247: Integer overflow leads to negative width |
| Date: | 2023-12-19 05:53:59 |
| Message-ID: | CAMbWs4-pYv=UkkdF_47w-a5OSgs5GQaZANib0YJc6mSp531Z5A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Dec 19, 2023 at 12:08 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> > I agree with all the comments made. I have also examined other places
> > where the width field is assigned, and I think we've covered all cases.
> > So the v3 patch is in good shape to me.
>
> Thanks for looking! Do you have an opinion about the int64-vs-double
> question?
To be honest, I don't have a preference on which one is better. I think
double is good enough for now as we don't need to worry about overflow
with it.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-12-19 09:20:44 | Re: BUG #18246: pgstathashindex() attempts to read invalid file for hash index attached to partitioned table |
| Previous Message | Tom Lane | 2023-12-19 04:08:57 | Re: BUG #18247: Integer overflow leads to negative width |