Re: Remove an unnecessary LSN calculation while validating WAL page header

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Remove an unnecessary LSN calculation while validating WAL page header
Date: 2022-10-12 02:20:18
Message-ID: CAMbWs4-mvs2hjAd7hM8aUd_rmBP0YU7aDKR8LW2HSMvdLekS0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 12, 2022 at 12:24 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:

> Knowing how difficult that code was, and how heroic was to change it to
> a more maintainable form, I place no blame on failing to notice that
> some small thing could have been written more easily.

Concur with that. The changes in 7fcbf6a4 made the code to a more
maintainable and readable state. It's a difficult but awesome work.

Thanks
Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2022-10-12 02:40:42 Allow WindowFuncs prosupport function to use more optimal WindowClause options
Previous Message Michael Paquier 2022-10-12 02:12:13 Re: shadow variables - pg15 edition