Re: Optimizer docs typos

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Optimizer docs typos
Date: 2020-05-18 10:45:11
Message-ID: CAMbWs4-U-ogzpchGsP2BBMufCss1hktm++eTJK_dUC196pw0cQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In this same README doc, another suspicious typo to me, which happens in
section "Optimizer Functions", is in the prefix to query_planner(),
we should have three dashes, rather than two, since query_planner() is
called within grouping_planner().

diff --git a/src/backend/optimizer/README b/src/backend/optimizer/README
index 7dcab9a..bace081 100644
--- a/src/backend/optimizer/README
+++ b/src/backend/optimizer/README
@@ -315,7 +315,7 @@ set up for recursive handling of subqueries
preprocess target list for non-SELECT queries
handle UNION/INTERSECT/EXCEPT, GROUP BY, HAVING, aggregates,
ORDER BY, DISTINCT, LIMIT
---query_planner()
+---query_planner()
make list of base relations used in query
split up the qual into restrictions (a=1) and joins (b=c)
find qual clauses that enable merge and hash joins

Thanks
Richard

On Mon, May 18, 2020 at 6:00 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
wrote:

> On Mon, May 18, 2020 at 6:56 PM Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
> > On Mon, May 18, 2020 at 11:31 AM Daniel Gustafsson <daniel(at)yesql(dot)se>
> wrote:
> >> Attached diff fixes two small typos in the optimizer README.
>
> > Pushed, thanks.
>
> Thank you!
>
> Best regards,
> Etsuro Fujita
>
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2020-05-18 12:07:52 Re: Performance penalty when requesting text values in binary format
Previous Message Amit Kapila 2020-05-18 10:40:40 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions