Re: [PATCH] Simple code cleanup in tuplesort.c.

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Xing Guo <higuoxing(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Simple code cleanup in tuplesort.c.
Date: 2022-09-16 06:43:04
Message-ID: CAMbWs4-Mn=jBwaiXCLi1WvPsw3Hc-5MDf-zBTwZVwfkwFNvQ+Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 27, 2022 at 5:10 PM Xing Guo <higuoxing(at)gmail(dot)com> wrote:

> The bounded heap sorting status flag is set twice in sort_bounded_heap()
> and tuplesort_performsort(). This patch helps remove one of them.
>

Revisiting this patch I think maybe it's better to remove the setting of
Tuplesort status from tuplesort_performsort() for the TSS_BOUNDED case.
Thus we keep the heap manipulation routines, make_bounded_heap and
sort_bounded_heap, consistent in that they update their status
accordingly inside the function.

Also, would you please add it to the CF to not lose track of it?

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2022-09-16 06:47:36 Re: Remove dead macro exec_subplan_get_plan
Previous Message Kyotaro Horiguchi 2022-09-16 06:36:29 Re: Switching XLog source from archive to streaming when primary available