Remove some redundant set_cheapest() calls

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Remove some redundant set_cheapest() calls
Date: 2024-03-26 11:02:48
Message-ID: CAMbWs4-KFEU_fDuJPNCOkUu3rwvZvKBEytkd9VrM4kH4-2h1CQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I happened to notice that the set_cheapest() calls in functions
set_namedtuplestore_pathlist() and set_result_pathlist() are redundant,
as we've centralized the set_cheapest() calls in set_rel_pathlist().

Attached is a trivial patch to remove these calls.

BTW, I suspect that the set_cheapest() call in set_dummy_rel_pathlist()
is also redundant. The comment there says "This is redundant when we're
called from set_rel_size(), but not when called from elsewhere". I
doubt it. The other places where it is called are set_append_rel_size()
and set_subquery_pathlist(), both being called from set_rel_size(). So
set_cheapest() would ultimately be called in set_rel_pathlist().

Thoughts?

Thanks
Richard

Attachment Content-Type Size
v1-0001-Remove-some-redundant-set_cheapest-calls.patch application/octet-stream 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2024-03-26 11:05:16 Re: Introduce XID age and inactive timeout based replication slot invalidation
Previous Message shveta malik 2024-03-26 10:47:53 Re: Introduce XID age and inactive timeout based replication slot invalidation