Re: SPI_connect, SPI_connect_ext return type

From: Stepan Neretin <sndcppg(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: SPI_connect, SPI_connect_ext return type
Date: 2024-08-10 14:45:01
Message-ID: CAMaYL5b6hVHZVn6AAbpok3kmz4fSGyfs7TbCY5N27CLFCH6GCw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> >That would break a lot of code (much of it not under our control) to
> little purpose; it would also foreclose the option to return to using
> SPI_ERROR_CONNECT someday.
>

Agree, it makes sense.
The only question left is, is there any logic in why in some places its
return value of these functions is checked, and in some not? Can I add
checks everywhere?
Best Regards, Stepan Neretin.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-08-10 15:17:27 Re: optimizing pg_upgrade's once-in-each-database steps
Previous Message Jelte Fennema-Nio 2024-08-10 14:27:02 Re: libpq: Fix lots of discrepancies in PQtrace