From: | Akshat Jaimini <destrex271(at)gmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, pgsql-www(at)lists(dot)postgresql(dot)org |
Subject: | Re: Broken Urls present on the official PostgreSQL website (as reported by the Testing Harness Suite) |
Date: | 2023-07-25 09:25:48 |
Message-ID: | CAMaW3Vh6=1hQ4MRWW3wKAFOssA4-4eopjCUVM3VW4kR3Y7NBTw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-www |
With the recent patches, there are no logs related to broken links as
generated by the testing harness.
I think we can mark these issues as completed now!
On Tue, Jul 25, 2023 at 1:42 PM Akshat Jaimini <destrex271(at)gmail(dot)com> wrote:
> Yup just checked it and we'll make sure to exclude the fixture data. These
> dynamic urls will be checked by the tests written to check documentation
> loading and rendering from now on. Will push the change eod today.
> Apologies for the inconvenience caused with the first two results.
> Will share the correct reports asap.
>
> Thanks,
> Akshat Jaimini
>
> On Tue, Jul 25, 2023 at 1:01 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> > On 25 Jul 2023, at 04:08, Jonathan S. Katz <jkatz(at)postgresql(dot)org>
>> wrote:
>> >
>> > On 7/24/23 2:22 PM, Akshat Jaimini wrote:
>> >
>> >> > The broken links present in the log file attached below are:
>> >> >
>> >> > --- Links to external sites -----
>> >> > 1. https://www.postgresql.org/docs/current/static/pgstandby.html
>> >> <https://www.postgresql.org/docs/current/static/pgstandby.html>
>> >> > <https://www.postgresql.org/docs/current/static/pgstandby.html
>> >> <https://www.postgresql.org/docs/current/static/pgstandby.html>> :
>> >> 404 :
>> >> > On Page https://www.postgresql.org/about/featurematrix/
>> >> <https://www.postgresql.org/about/featurematrix/>
>> >> > <https://www.postgresql.org/about/featurematrix/
>> >> <https://www.postgresql.org/about/featurematrix/>>
>> >> > 2. https://www.postgresql.org/docs/current/static/tsearch2.html
>> >> <https://www.postgresql.org/docs/current/static/tsearch2.html>
>> >> > <https://www.postgresql.org/docs/current/static/tsearch2.html
>> >> <https://www.postgresql.org/docs/current/static/tsearch2.html>> :
>> 404 :
>> >> > On Page https://www.postgresql.org/about/featurematrix/
>> >> <https://www.postgresql.org/about/featurematrix/>
>> >> > <https://www.postgresql.org/about/featurematrix/
>> >> <https://www.postgresql.org/about/featurematrix/>>
>> >
>> > I was unable to find either of these links when searching the feature
>> matrix database. Is there any other info that can narrow down which entry
>> these are in? Otherwise, these may have already been removed.
>>
>> I'm guessing this ran against the featurematrix/fixtures/data.json in the
>> pgweb
>> repo which does contain these links, but which doesn't reflect the actual
>> website content due to being an initial dataset (in turn generated by the
>> script pgweb/dump_initial_data.sh).
>>
>> The data.json being served on the production site is based off the
>> database and
>> isn't committed to the repository. A testing harness for the website code
>> should probably skip checking the validity of dynamic data unless it's
>> running
>> against the live site for those checks.
>>
>> --
>> Daniel Gustafsson
>>
>>
From | Date | Subject | |
---|---|---|---|
Next Message | Karen Jex | 2023-07-25 12:32:38 | Request editor access to the wiki |
Previous Message | Daniel Gustafsson | 2023-07-25 08:14:06 | Re: Cleaning up the books page |