Re: Some pgq table rewrite incompatibility with logical decoding?

From: Jeremy Finzel <finzelj(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Some pgq table rewrite incompatibility with logical decoding?
Date: 2018-09-01 16:25:58
Message-ID: CAMa1XUhf5FSmiJ=HF2puMmwKtNX9zHDuLF1pu0DSUFX+Spwziw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
>
Interesting.
>
> So you were running 9.6.9 before, it triggered the issue (and was not
> able to recover). You took a filesystem snapshot, started a 9.6.10 on
> the snapshot, and it recovered without hitting the issue?
>

I am resposting this to the list and not only to Tomas. Tomas, I can’t
promise just yet to delve into this because given the patch fixes the issue
it’s obviously much lower priority for our team. Are you hoping for me to
confirm the exact scenario in which the 9.6.10 patch fixes the bug?

Actually, there were more things changed than that so I'm not positive it
was the last patch:

BEFORE:
Provider - 9.6.8-1.pgdg16.04+1, pglogical 2.1.1-1.xenial+1
Subscriber - 9.6.9-2.pgdg16.04+1, 2.1.1-1.xenial+1

AFTER:
Provider - 9.6.10-1.pgdg16.04+1, pglogical 2.2.0-3.xenial+1
Subscriber - 9.6.10-1.pgdg16.04+1, pglogical 2.2.0-3.xenial+1

> I quickly went through the commits in 9.6 branch between 9.6.9 and
> 9.6.10, looking for stuff that might be related, and these three commits
> seem possibly related (usually because of invalidations, vacuum, ...):
>
> 6a46aba1cd6dd7c5af5d52111a8157808cbc5e10
> Fix bugs in vacuum of shared rels, by keeping their relcache entries
> current.
>
> da10d6a8a94eec016fa072d007bced9159a28d39
> Fix "base" snapshot handling in logical decoding
>
> 0a60a291c9a5b8ecdf44cbbfecc4504e3c21ef49
> Add table relcache invalidation to index builds.
>
> But it's hard to say if/which of those commits did the trick, without
> more information.
>

Let me know if that info gives you any more insight - actually 2 point
version jumps for provider, 1 for subscriber.

Thanks,
Jeremy

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-09-01 16:52:16 Re: Reopen logfile on SIGHUP
Previous Message Lars Kanis 2018-09-01 16:17:16 [PATCH] Fix docs to JOHAB encoding on server side