Re: Require suggestions on issue #7811

Hi Dave,

This isn't the issue in the case of sqlite db while using persistent
storage. Issue appears only if external database is used as pgadmin
configuration db. Just having different way of persistent storage( in this
case backend database) behaviour should not be different.

Also, on restart admin user specified while container is not recreated.
Can't we fix on similar lines?

Thanks,
Yogesh Mahajan
EnterpriseDB

On Tue, Sep 3, 2024 at 2:05 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Tue, 3 Sept 2024 at 09:29, Pravesh Sharma <
> pravesh(dot)sharma(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> On Tue, Sep 3, 2024 at 1:47 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Tue, 3 Sept 2024 at 09:10, Pravesh Sharma <
>>> pravesh(dot)sharma(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> I am working on issue #7811
>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7811>, where using an
>>>> external database for storing pgAdmin configuration results in duplicate
>>>> server entries when a container with a mapped servers.json file is
>>>> restarted.
>>>>
>>>> The proposed solution is to implement a check when loading servers. We
>>>> would verify the server’s name, host, port, and username to determine if
>>>> the server already exists in the database. If it does, we would skip
>>>> registering it again.
>>>>
>>>>
>>>> Please share any suggestions or feedback on this approach.
>>>>
>>>
>>> I would say "Won't fix". If someone is using persistent storage for
>>> settings, why launch containers to import the same servers over and over
>>> again? Just load them once, manually.
>>>
>> What if the container needs to be restarted? In that case it will again
>> import the server making a duplicate entry.
>>
>
> Not if the servers are manually imported rather than through servers.json.
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>