From: | Hannu Krosing <hannuk(at)google(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: What is a typical precision of gettimeofday()? |
Date: | 2024-07-02 18:15:59 |
Message-ID: | CAMT0RQQXzkL=QREKtu1esiNbD5k0ULJF9Jb2fgBuYOJSwegpPA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jul 2, 2024 at 7:50 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > Do we also need tests for this one ?
>
> Yeah, it was annoying me that we are eating the overhead of a TAP test
> for pg_test_timing and yet it covers barely a third of the code [1].
> We obviously can't expect any specific numbers out of a test, but I
> was contemplating running "pg_test_timing -d 1" and just checking for
> (a) zero exit code and (b) the expected header lines in the output.
At least "does it run" tests should be there -
For example with the current toolchain on MacOS I was able to compile
__builtin_readcyclecounter(); but it crashed when the result was
executed.
The same code compiled *and run* fine on same laptop with Ubuntu 24.04
We might also want to have some testing about available speedups from
pg_bitmanip.h being used, but that could be tricky to test in an
universal way.
--
Hannu
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-07-02 18:33:41 | Re: What is a typical precision of gettimeofday()? |
Previous Message | Tom Lane | 2024-07-02 18:15:09 | Re: An improved README experience for PostgreSQL |