Re: [pgAdmin4] [PATCH] Simplify Server's python setup

From: Jan Alexander Steffens <jan(dot)steffens(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4] [PATCH] Simplify Server's python setup
Date: 2017-01-25 13:43:28
Message-ID: CAMQ-g0dkzHWvG4DoZj9JLpOvwymn+T3K9naZPFsNPbj_3ZrBtw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jan 25, 2017 at 12:39 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> As far as I can see, this breaks usage in development environments, or
> any configurations where the Python code may be separated from the
> runtime. Am I missing something?
>

What kind of setup are you talking about? It's not clear to me.

If the venv doesn't exist, the program name becomes "/python" and you get
the standard environment including whatever packages you installed with
"pip install" or "pip install --user".

Granted, "/python" is nonsense and should probably just be "python". Also,
I think PATH doesn't need to be touched at all anymore, so the lines
involving pathEnv can be removed.

How about a settings key to force the program name? That would allow
choosing any other virtualenv to run with.

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-01-25 13:57:32 Re: [pgAdmin4] [PATCH] Simplify Server's python setup
Previous Message Dave Page 2017-01-25 13:21:49 Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL