Re: [PATCH] Find additional connection service files in pg_service.conf.d directory

From: "Andreas 'ads' Scherbaum" <adsmail(at)wars-nicht(dot)de>
To: Curt Tilmes <curt(at)tilmes(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Find additional connection service files in pg_service.conf.d directory
Date: 2018-03-05 12:45:23
Message-ID: CAMDzVO8seF7yaA1pYcB-fOMq=KDKOGnUHnq=TRiE-fDr27i5gQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 1, 2018 at 7:40 PM, Curt Tilmes <curt(at)tilmes(dot)org> wrote:

> On Thu, Mar 1, 2018 at 1:13 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>

> > I'd also insist that the file ending is ".conf".
>
> New patch limits files to ".conf".
>

Looked over this patch and found that you limit the directory entries to
files only.
Would it make sense to allow links as well? That would allow other
programs/distributions to place a link in the config directory and point to
a service file in their own directory.

Regards,

--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2018-03-05 12:49:41 Re: [PoC PATCH] Parallel dump to /dev/null
Previous Message Etsuro Fujita 2018-03-05 12:44:37 Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw