Re: [PGAGENT] Upgrade pgAgent from unpackaged version

From: Rushabh Lathia <rushabh(dot)lathia(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PGAGENT] Upgrade pgAgent from unpackaged version
Date: 2018-06-14 04:49:27
Message-ID: CAMBO3tUqYuONeAzs4YStKvj4etSDKD0xKKvU=xSMA-7-9yGCMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks Ashesh and Dave.

I verified the changes and it looks good to me. I found that newly
added unpackaged file still have old file header comment. Which
require change with new file name.

PFA patch to fix the same.

Thanks,

On Wed, Jun 13, 2018 at 6:10 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, applied.
>
> On Wed, Jun 13, 2018 at 5:11 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> As per my conversation with Rushabh, we need to rename the
>> pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the
>> current version has changed. We also need to update the schema version
>> function for the unpackaged extension.
>>
>> Please find the attached patch for the same.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
--

Rushabh Lathia
Database Architect
EnterpriseDB Corporation
The Enterprise Postgres Company

Phone: +91-20-30589494

Website: http://www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

Attachment Content-Type Size
unpackaged_file_header_change.patch text/x-patch 531 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2018-06-14 05:39:01 [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted
Previous Message pgAdmin 4 Jenkins 2018-06-13 17:11:05 Jenkins build is back to normal : pgadmin4-master-python27 #646