Re: [pgAdmin][patch] Use unique DB name in ERD API test cases

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][patch] Use unique DB name in ERD API test cases
Date: 2021-02-04 09:31:54
Message-ID: CAM9w-_nuvuEreprufLtAxDVPTXTF1GGP9nZZhX8xpu_QzQ4o4g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Seems like the test cases are still failing on the build machines.
Attached is the patch to make the connection ids unique by using random.
Please review.

On Wed, Feb 3, 2021 at 4:49 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied.
>
> On Wed, Feb 3, 2021 at 4:01 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to use unique DB names in ERD API test cases to
>> avoid conflict when running test cases in parallel.
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
ERD.apitests_v2.patch application/octet-stream 7.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2021-02-04 10:45:02 pgAdmin 4 commit: Fixed API test cases by making the connection id uniq
Previous Message Akshay Joshi 2021-02-04 09:20:34 pgAdmin 4 commit: Fixed an issue where utility(Backup, Maintenance, ...