Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

Hi Hackers,

Attached is the updated patch to fix the review comments of trailing mail.
Kindly review.

On Thu, Jun 27, 2019 at 4:49 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> On Wed, Jun 26, 2019 at 8:22 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> Something isn't working correctly - I turned on the summary option, and
>>> this is the query that was run when I hit the EXPLAIN button:
>>>
>>> EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING
>>> False,SUMMARY False,BUFFERS False) select * from pg_tables
>>>
>>
>>> Aside from the formatting (s/True/true, s/False/false, missing spaces
>>> etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle
>>> caches, rebundled etc.
>>>
>> I think I misunderstood the documents -
>> https://www.postgresql.org/docs/12/sql-explain.html. Few of the
>> parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will
>> make the changes, along with formatting to existing codes as well.
>>
>
> I'm not sure that explains why the summary option is set to *false* for an
> EXPLAIN action, but anyway, please make sure it works :-)
>
>
>>
>>> Shouldn't there also be documentation updates?
>>>
>> Yeah. (I always miss that :/)
>>
>>>
>>> On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch to add support for SETTINGS(v12+) and
>>>> SUMMARY(v10+) explain options. These options will be visible only if
>>>> version is supported.
>>>>
>>>> I have also created and fixed RM4395. The explain options changed on
>>>> one query tool should not change explain options on other query tools or
>>>> preferences. The initial values will be taken from preferences are usual.
>>>>
>>>> Kindly review.
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"