| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided |
| Date: | 2019-09-13 06:13:23 |
| Message-ID: | CAM9w-_nq+9oCmS+7SM7EiDynLbv+5untskr5PnkRMJrt+YzsGw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Looks good to me.
On Fri, Sep 13, 2019 at 8:05 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Can someone please review this.
>
> On Mon, 9 Sep, 2019, 18:06 Akshay Joshi, <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the RM #4642 "port should not be mandatory
>> when a service is provided". *Cyril Jouve* has sent the initial patch,
>> but that only removes the validation on GUI, when we save the server
>> properties without port and username backend throws an error because port
>> and username is *NOT NULL* columns in the server table in SQLite.
>>
>> I have removed the *NOT NULL *constraint from the port and username. The
>> maintenance database is required as our whole connection logic is based on
>> that, so I have added the NOT NULL constraint for that column.
>>
>> Please review it.
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-09-13 06:24:24 | pgAdmin 4 commit: Ensure port and username should not be mandatory when |
| Previous Message | Akshay Joshi | 2019-09-13 06:11:36 | pgAdmin 4 commit: Fix webpack issue where multiple assets emit to the s |