Re: [pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode
Date: 2020-05-28 12:46:49
Message-ID: CAM9w-_nhtSuDXzrxiXRA2RVGx0Lg21VWcu1tMScPThyjiLBVbA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the updated patch. Please review.

On Thu, May 28, 2020 at 5:38 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya
>
> When I run setup.py and specify the *--sqlite-path* parameter like below:
> python setup.py --sqlite-path
> "/Users/akshayjoshi/Downloads/pgadmin4-dev-env.db" --dump-servers
> output.json
>
> I got the following error:
>
> PermissionError: [Errno 13] Permission denied: '/var/lib/pgadmin'
>
> Please fix it and resend the patch.
>
> On Thu, May 28, 2020 at 2:39 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to:
>> 1) Fix an issue when dumping servers from a desktop pgAdmin app by
>> providing an option --sqlite-path. This will allow the user to dump a
>> specific config db file.
>> 2) While there is an option for --sqlite-path now, the other paths for
>> session, storage, etc. were failing with permission errors. Code is changed
>> to not to bother those directories when dumping or loading servers.
>> 3) Improved --help for setup.py.
>> 4) Docs updated.
>>
>> Please review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM5521_v2.patch application/octet-stream 9.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2020-05-28 15:04:15 pgAdmin 4 commit: Don't try to import the signing key. YUM/RPM will do
Previous Message Akshay Joshi 2020-05-28 12:46:02 Re: [pgAdmin4][Patch] - RM 5416 Cannot close/remove a tab/panel without saving