Re: [pgAdmin4] Questions about trigger properties's Fires in edit mode

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: "zhangjie2(at)fujitsu(dot)com" <zhangjie2(at)fujitsu(dot)com>
Cc: "pgadmin-hackers(at)lists(dot)postgresql(dot)org" <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [pgAdmin4] Questions about trigger properties's Fires in edit mode
Date: 2021-07-29 10:17:16
Message-ID: CAM9w-_natyP6o6vXuwvG4MsnDpXFZnfBNgd3ywgjftSKysNu6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

PostgreSQL allows an alter only for name -
https://www.postgresql.org/docs/current/sql-altertrigger.html. Even if we
enable it, we cannot generate the SQL for the change.

On Thu, Jul 29, 2021 at 3:23 PM zhangjie2(at)fujitsu(dot)com <zhangjie2(at)fujitsu(dot)com>
wrote:

> Hi, all
>
> In trigger's Properties screen, the 'fires' is disabled.
> What is the reason why 'fires' is disabled?
> I think it should be the same as 'evnt_insert',
> When server_type is ppas and in edit mode, 'fires' is disabled.
>
> file:
> web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/static/js/trigger.js
>
> id: 'fires', label: gettext('Fires'), deps: ['is_constraint_trigger'],
> mode: ['create','edit', 'properties'], group: gettext('Events'),
>
> disabled: function(m) {
> if (!m.isNew()) ★ In edit mode, 'fires' is disabled.
> return true;
> // If contraint trigger is set to True then only enable it
> var is_constraint_trigger = m.get('is_constraint_trigger');
> if(!m.inSchemaWithModelCheck.apply(this, [m])) {
> if(!_.isUndefined(is_constraint_trigger) &&
> is_constraint_trigger === true) {
> setTimeout(function() { m.set('fires', 'AFTER'); }, 10);
> return true;
> } else {
> return false;
> }
> } else {
> // Check if it is row trigger then enabled it.
> var fires_ = m.get('fires');
> if (!_.isUndefined(fires_) &&
> m.node_info['server']['server_type'] == 'ppas') {
> return false;
> }
> // Disable it
> return true;
> }
>
>
>

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2021-07-29 11:45:33 [pgAdmin][RM-6592]: [React] Port Materialized View node to react
Previous Message zhangjie2@fujitsu.com 2021-07-29 09:53:20 [pgAdmin4] Questions about trigger properties's Fires in edit mode