From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences |
Date: | 2019-08-29 06:58:46 |
Message-ID: | CAM9w-_nVWi1ngsT+U0VD0=XVnhGm7QwSu6cVahCSs_6XVaCbSw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
Attached is the updated patch.
The patch also includes some RE-SQL log additions and a change in resql
code where msql was failing if scenario data had dict data types. Code is
changed to convert dict to string before forming the URL.
Kindly review.
On Thu, Aug 29, 2019 at 11:28 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Kindly hold on with the patch. I think I have missed few things. :P
> Will send an updated patch.
>
> On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch containing further changes to sequences RE-SQL test
>> cases. Changes include MSQL test cases, ACL test cases and allow run
>> sequences test cases on EPAS servers.
>>
>> Kindly review.
>>
>> On Mon, Jul 15, 2019 at 7:26 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Thanks, committed.
>>>
>>> On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch to add RE-SQL test cases for sequences. When
>>>> running the test cases, I also found an issue (#4470
>>>> <https://redmine.postgresql.org/issues/4470>). The fix for it is
>>>> included in the patch.
>>>>
>>>> Kindly review.
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
RM4469.part2_v2.patch | application/octet-stream | 30.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2019-08-29 07:41:14 | [pgAdmin][RM4663] Query history throws python exception on python 2.7 |
Previous Message | Aditya Toshniwal | 2019-08-29 05:58:16 | Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences |