Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>, Chethana Kumar <chethana(dot)kumar(at)enterprisedb(dot)com>
Subject: Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the
Date: 2019-12-03 10:43:04
Message-ID: CAM9w-_nEu37PsKRGLNeEEQLMfjpnYWmBfDCFa6p5sCxT2BTFaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

I've sent a patch for the new icon. It is not a play icon but thoughts on
the sent patch ? Below is the icon:
[image: toolbar.png]

On Tue, Dec 3, 2019 at 4:09 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> I intentionally didn't change that one as I wasn't sure what icon would be
> better. I'm far from convinced that it should also be a play icon.
>
> On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to change toolbar icon for opening query tool
>> inline with execute button change.
>> Icon for table filter button on the toolbar is also changed as below:
>> [image: toolbar.png]
>>
>> On Tue, Dec 3, 2019 at 7:15 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Use a 'play' icon for the Execute Query button in the Query Tool for
>>> greater consistency with other applications. Fixes #4711
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>>
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2bd5e6ee7c41d5fc2f4ee0036042ac79ff9320
>>>
>>> Modified Files
>>> --------------
>>> docs/en_US/release_notes_4_16.rst | 1 +
>>> web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +-
>>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>>
>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shubham Agarwal 2019-12-03 12:39:34 Re: Fixes for pgAdmin feature tests
Previous Message Dave Page 2019-12-03 10:39:40 Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the