Re: [pgAdmin][RM4279] : Issue with File Browser Home button

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Yogesh Jain <yogesh(dot)jain(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4279] : Issue with File Browser Home button
Date: 2020-04-27 03:34:27
Message-ID: CAM9w-_n4PZAy4T2mdk_yRaM8xvKTuakPQWiz=SsZnxARccyjUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Yogesh,

Just did an eyeball review. You've included homedir path in the response
rendered JS file. You're exposing underlying directory structure to users
even in server mode. This is not appropriate. This info should remain at
the server and not at the client side.
+ homedir=os.path.expanduser('~'),

On Fri, Apr 24, 2020 at 7:26 PM Yogesh Jain <yogesh(dot)jain(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
>
> Attached is the patch to fix the issue with the file browser Home button.
>
> FYI : While clicking on the home button it was pointing to the user's root
> directory rather than home directory, which is fixed in this patch.
>
> Please review.
> PFA.
>
> --
> Regards,
> Yogesh Jain
> 8982696654
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2020-04-27 03:59:47 [pgAdmin4][Patch] - Improve LDAP Error messages
Previous Message Domenico Sgarbossa 2020-04-26 18:18:12 Re: Translators: Release next week