From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Anil Sahoo <anil(dot)sahoo(at)enterprisedb(dot)com> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Regarding feature #3319 |
Date: | 2024-08-20 04:44:04 |
Message-ID: | CAM9w-_n-Uh=rvV6CTESUnoiiUaUa2vxao7SJBVrrv1E0uMWRpQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Anil,
There can be multiple query tools open with large files. Not entirely sure
if storing in SQLite DB is a good idea.
External databases won't come in the picture as 99.99% users will not use
external DB for desktop app. We're only doing this for desktop app.
And also consider the case where a SQL file is opened with some unsaved
changes.
On Tue, Aug 20, 2024 at 9:11 AM Anil Sahoo <anil(dot)sahoo(at)enterprisedb(dot)com>
wrote:
> Hi Aditya,
>
> As we are already storing the query history in the pgAdmin 4's database
> file.
> I am planning to store the information the same way. That can be an
> internal database file like SQLite or external database.
>
> Let me know if you all have any suggestions on this.
>
> Thanks
> Anil
> --
>
> <http://www.enterprisedb.com>
>
> *Anil Sahoo*
>
> Software Engineer
>
> www.enterprisedb.com
>
> Power to Postgres
>
> <https://www.linkedin.com/company/edbpostgres>
> <https://twitter.com/edbpostgres?lang=en>
> <https://www.facebook.com/EDBpostgres>
> <https://www.instagram.com/EDBpostgres/>
>
>
> On Mon, Aug 19, 2024 at 11:40 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Anil,
>>
>> On Mon, Aug 12, 2024 at 3:02 PM Anil Sahoo <anil(dot)sahoo(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi,
>>>
>>> Yes, We will store the details that are needed to re-establish the
>>> connection.
>>>
>>
>> How/Where are you planning to store the information? Query text could be
>> large.
>>
>>>
>>> Regards
>>> Anil
>>> --
>>>
>>> <http://www.enterprisedb.com>
>>>
>>> *Anil Sahoo*
>>>
>>> Software Engineer
>>>
>>> www.enterprisedb.com
>>>
>>> Power to Postgres
>>>
>>> <https://www.linkedin.com/company/edbpostgres>
>>> <https://twitter.com/edbpostgres?lang=en>
>>> <https://www.facebook.com/EDBpostgres>
>>> <https://www.instagram.com/EDBpostgres/>
>>>
>>>
>>> On Mon, Aug 12, 2024 at 2:08 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> On Mon, 12 Aug 2024 at 06:50, Anil Sahoo <anil(dot)sahoo(at)enterprisedb(dot)com>
>>>> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>>
>>>>> This feature #3319
>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/3319>, demands the
>>>>> Workspace and the Query tool panel to be saved before exiting the
>>>>> application and on restart it will show earlier opened panels.
>>>>>
>>>>>
>>>>> We are already saving the Browser layout, Query tool layout and the
>>>>> Object explorer tree state but to save the contents of panels we will
>>>>> initially start with the Query tool. The below implementation will be done,
>>>>>
>>>>> 1. Store the query tool panels and the list of connections present
>>>>> in each query tool panel and the active connection
>>>>> 2. Store the query that is written in the editor
>>>>> 3. Store the contents of scratch pad
>>>>>
>>>>> The main reason that this has never been worked on is that there is no
>>>> way to restore the state of a connection to what it was and be sure we've
>>>> got it right. How do you propose to handle that? I assume in a similar way
>>>> to the warnings we give if a connection has to be re-established?
>>>>
>>>>>
>>>>>
>>>>>
>>>>> We will use debouncing to store the workspace data and all other data
>>>>> related to panels in the pgAdmin 4's configured database file. Through
>>>>> debouncing we will be able to call the API at certain intervals of user
>>>>> interaction, and it will update the stored data related to workspace and
>>>>> all other panels.
>>>>>
>>>>
>>>> OK.
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>> <https://www.enterprisedb.com/>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/>
"Don't Complain about Heat, Plant a TREE"
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2024-08-20 09:07:17 | Re: pgAdmin4 v8.11 candidate builds |
Previous Message | Anil Sahoo | 2024-08-20 03:40:41 | Re: Regarding feature #3319 |