| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Patch] - Improve schema field validation order |
| Date: | 2022-06-15 09:50:40 |
| Message-ID: | CAM9w-_n=Dy+fDs8gQWifxJOek5JMb4GXFDUy9Hzc5zei77DJqA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Yogesh,
You have moved the validate call inside the loop, which will call the
validate method once for all the fields.
So in a form for 50 fields if I type anything in a field then it will call
the validate method 50 times.
I do not agree with this code change.
On Wed, Jun 15, 2022 at 2:43 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch which corrects validation flow of the
> parent & nested schema fields.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Mohite | 2022-06-20 07:42:45 | Re: [pgAdmin][RM-6132]: [React] Port debugger to React |
| Previous Message | Yogesh Mahajan | 2022-06-15 09:12:46 | [Patch] - Improve schema field validation order |