Re: pgAdmin 4 commit: Upgrade font awesome from v4 to v5. Fixes #5731

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Upgrade font awesome from v4 to v5. Fixes #5731
Date: 2020-08-13 09:54:13
Message-ID: CAM9w-_ms8_Sy00OUCX4zN=Utp=kO2Qdw+JbQnwMaA89Fkw8FrQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Attached patch has few more fixes for supporting font awesome v5.
Please review.

On Thu, Aug 13, 2020 at 12:04 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Upgrade font awesome from v4 to v5. Fixes #5731
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93adf6884f031ff0e02c60736d9d4588732fdd07
> Author: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
>
> Modified Files
> --------------
> docs/en_US/release_notes_4_25.rst | 1 +
> web/package.json | 4 ++--
> .../servers/databases/schemas/views/static/js/mview.js | 4 ++--
> .../servers/databases/static/js/database.js | 2 +-
> .../browser/server_groups/servers/static/js/server.js | 4 ++--
> .../servers/tablespaces/static/js/tablespace.js | 2 +-
> web/pgadmin/browser/static/js/browser.js | 2 +-
> web/pgadmin/browser/static/js/collection.js | 4 ++--
> web/pgadmin/browser/static/js/node.js | 10 +++++-----
> web/pgadmin/browser/static/js/node.ui.js | 2 +-
> web/pgadmin/browser/static/js/wizard.js | 2 +-
> .../templates/dashboard/database_dashboard.html | 2 +-
> .../templates/dashboard/server_dashboard.html | 2 +-
> web/pgadmin/help/__init__.py | 4 ++--
> web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 4 ++--
> web/pgadmin/misc/file_manager/static/js/utility.js | 12 ++++++------
> .../file_manager/templates/file_manager/index.html | 6 +++---
> web/pgadmin/misc/static/explain/js/explain.js | 4 ++--
> web/pgadmin/static/css/style.css | 2 +-
> web/pgadmin/static/js/backform.pgadmin.js | 6 +++---
> web/pgadmin/static/js/backgrid.pgadmin.js | 6 +++---
> .../static/js/sqleditor/history/query_sources.js | 2 +-
> web/pgadmin/static/js/sqleditor_utils.js | 2 +-
> web/pgadmin/static/scss/_aci_tree.overrides.scss | 4 ++++
> web/pgadmin/static/scss/_alertify.overrides.scss | 2 ++
> web/pgadmin/static/scss/_backform.overrides.scss | 1 +
> web/pgadmin/static/scss/_bootstrap.overrides.scss | 2 ++
> web/pgadmin/static/scss/_codemirror.overrides.scss | 2 ++
> web/pgadmin/static/scss/_pgadmin.style.scss | 18
> ++++++++++++++++++
> web/pgadmin/static/scss/_webcabin.pgadmin.scss | 1 +
> .../static/scss/resources/_default.variables.scss | 2 +-
> web/pgadmin/tools/backup/static/js/backup.js | 12 ++++++------
> .../tools/datagrid/static/js/datagrid_panel_title.js | 2 +-
> .../tools/datagrid/templates/datagrid/index.html | 12 ++++++------
> .../tools/grant_wizard/static/js/grant_wizard.js | 4 ++--
> .../schema_diff/static/js/schema_diff.backform.js | 2 +-
> .../tools/schema_diff/static/scss/_schema_diff.scss | 3 +++
> web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 2 +-
> .../tools/sqleditor/static/scss/_sqleditor.scss | 2 ++
> web/regression/feature_utils/locators.py | 4 ++--
> web/yarn.lock | 16
> ++++++++--------
> 41 files changed, 108 insertions(+), 72 deletions(-)
>
>

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
fa5_v2.patch application/octet-stream 7.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-08-13 12:19:26 pgAdmin 4 commit: 1) Added special handling for the extension to resolv
Previous Message Akshay Joshi 2020-08-13 09:48:07 Re: [pgAdmin][RM5731]:Upgrade the font awesome to version 5