| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - RM 5481 update is truncating data for type character with length |
| Date: | 2020-05-25 11:23:37 |
| Message-ID: | CAM9w-_mqLhsaw1j+Zo4Pd2ZcD-y6NCnkZvn0vzoAA4xzAAmrRA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Akshay,
The patch looks good to me. The test cases work fine. I've also tested with
custom domain types and is working fine.
On Mon, May 25, 2020 at 3:45 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Hackers,
>
> Attached is the patch to fix the data truncation issue when updating the
> data of the type character with length. To fix this issue I have created a
> ignore type cast list, where while inserting/updating we ignore the
> typecasting for the mentioned data type.
>
> Added test cases for character and bit Data Type.
>
> Please review it.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-05-25 11:41:34 | pgAdmin 4 commit: Update version for release. |
| Previous Message | Akshay Joshi | 2020-05-25 10:14:53 | [pgAdmin4][Patch] - RM 5481 update is truncating data for type character with length |