From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM6207] Update JS dependencies |
Date: | 2021-02-10 06:37:33 |
Message-ID: | CAM9w-_mmAdrVf+SAoEp_uKu6K3oM5RcHaYh1bHF31e_2vhLf8Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Aditya
>
> One jasmine test is failing, please fix that and resend the patch.
>
It was failing because of a side effect of some other test case. Fixed.
Please review.
>
> On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to update the JS dependencies to latest. Changes
>> include:
>> 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking
>> changes, so updated multiple webpack plugins and changed the config
>> accordingly.
>> 2) Replaced iconfont-webpack-plugin with a more maintained
>> webfonts-loader.
>> 3) Replaced deprecated babel-eslint with @babel/eslint-parser
>> 4) Replaced optimize-css-assets-webpack-plugin with a more maintained
>> css-minimizer-webpack-plugin
>> 5) Updated all other JS packages and made the required code changes.
>>
>> Note, there is an update available for slickgrid and I tried to update
>> it. But it was not working as expected. So without wasting time, I've not
>> updated slickgrid, and can be updated as a separate task.
>>
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
RM6207_v2.patch | application/octet-stream | 499.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Yogesh Mahajan | 2021-02-10 07:17:23 | [pgAdmin4][Patch] - API Tests Tear-down Fix |
Previous Message | Dave Page | 2021-02-09 16:15:15 | pgAdmin 4 commit: Fix filenames. |