Re: [pgAdmin][RM7350] More query tool fixes

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM7350] More query tool fixes
Date: 2022-05-09 06:20:37
Message-ID: CAM9w-_mirgOo_mMEFCMEUoAfiQTOUQq1oKv2xWixMHetcBfLzA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Since this is not committed yet. Adding a few more fixes. Patch fixes:
1. Warning/Confirm dialogs should be inside the query tool.
2. The Help button in View/Edit data should open the corresponding help
page.
3. Disable execute options when query tool in transaction.
4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent.
Use a fork till then.
5. NOTICE messages should not be part of Notifier success popups.

Please review.

On Fri, May 6, 2022 at 2:39 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Please ignore the previous patch. Added one more fix. Patch fixes:
> 1. Warning/Confirm dialogs should be inside the query tool.
> 2. The Help button in View/Edit data should open the corresponding help
> page.
> 3. Disable execute options when query tool in transaction.
>
> On Fri, May 6, 2022 at 9:58 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached patch fixes:
>> 1. Warning/Confirm dialogs should be inside the query tool.
>> 2. The Help button in View/Edit data should open the corresponding help
>> page.
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM7350v3.patch application/octet-stream 10.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2022-05-09 07:15:35 pgAdmin 4 commit: Update Italian translation.
Previous Message fred.escallier 2022-05-08 04:22:25 french translation update