From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch for SonarQube code scan fixes. |
Date: | 2020-09-08 10:00:52 |
Message-ID: | CAM9w-_mgC6O1Pb36F_BiG8mt5_5BRAT1XCO0etkLCO+Ux78o8A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
sqlautocomplete code is mostly inherited from the pgcli project. Changing
it might create trouble in updating the code with new versions.
On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
wrote:
> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. psycopg2/connection:
>
> - Refactor this function to reduce its Cognitive Complexity from 32 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 17 to
> the 15 allowed.
>
> 2. psycopg2/server_manager:
>
> - Refactor this function to reduce its Cognitive Complexity from 20 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 33 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 26 to
> the 15 allowed.
>
> 3. sqlautocomplete/parseutils:
>
> - Refactor this function to reduce its Cognitive Complexity from 23 to
> the 15 allowed.
>
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2020-09-08 10:23:08 | Re: Patch for SonarQube code scan fixes. |
Previous Message | Nikhil Mohite | 2020-09-08 09:28:58 | Patch for SonarQube code scan fixes. |