Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes
Date: 2020-07-03 07:17:15
Message-ID: CAM9w-_mcbpeO8vWcVGeXqP=XXTOigrD+DT9vkfne7_FZARUBbg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

The jasmine test cases are failing with this commit. Attached is the patch
to fix the test cases.

On Fri, Jul 3, 2020 at 11:49 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied.
>
> On Thu, Jul 2, 2020 at 5:54 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to:
>> 1) Change the way editable field is displayed in backgrid.
>> 2) Change colors for alerts in dark theme.
>> 3) Change the dashboard graph grid lines colors based on theme.
>> 4) Fix the backgrid hover background issue. Fixes #5470.
>> 5) Few other CSS improvements.
>>
>> Please review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM5287.jasmine.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-07-03 07:28:04 pgAdmin 4 commit: Fixed jasmin test cases failed due to last commit.
Previous Message Akshay Joshi 2020-07-03 06:20:21 Re: Patch for SonarQube code scan fixes