Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab
Date: 2021-02-09 08:52:35
Message-ID: CAM9w-_m_qrZsT2FBZHa4hGkQ45XF5xDjWzyTJAonoiZoxoUbDg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Akshay,

The previous patch will fix the dashboard issue also.

On Tue, Feb 9, 2021 at 12:41 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya
>
> Please fix the issue for Dashboard API calls as well and send the patch
> again.
>
> On Mon, Feb 8, 2021 at 5:39 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> The changes for not calling the ajax until the panel is focused were
>> missed in the last patch. Please review the attached.
>>
>> On Wed, Feb 3, 2021 at 1:00 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Tue, Feb 2, 2021 at 5:44 PM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached patch will allow closing Statistics, Dependencies, Dependants
>>>> tabs. The tabs can be added back by right clicking on the tab strip and
>>>> selecting "Add panel", similar to that of Dashboard.
>>>> Changes are also made to make sure statistics, dependencies, dependants
>>>> are fetched only when they're visible, to avoid unnecessary ajax calls.
>>>>
>>>> Please review.
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>>> <http://edbpostgres.com>
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2021-02-09 10:58:27 pgAdmin 4 commit: Ensure that ajax request for Dashboard, Statistics, D
Previous Message Akshay Joshi 2021-02-09 07:10:59 Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab