Re: ​Support JSON Editor for JSON type data in pgAdmin

On Thu, Jul 15, 2021 at 7:13 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Thank you for your input.
> Attached screen shots are actual one.The Integration part is done.
> The Styling part is in progress & it will be done in accordance to pgAdmin
> theme.
>
And as we discussed, lazy load the JSON editor library only if required.

>
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Thu, Jul 15, 2021 at 6:18 PM Dave Page <dave(dot)page(at)enterprisedb(dot)com>
> wrote:
>
>> Hi
>>
>> On Thu, Jul 15, 2021 at 12:57 PM Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave/Team,
>>> As part of Feature #519 <https://redmine.postgresql.org/issues/5198>8
>>> <https://redmine.postgresql.org/issues/5198> current text editor in
>>> data-grid is enhanced using this
>>> <https://www.npmjs.com/package/jsoneditor> json editor for json type
>>> data.
>>> This is licensed under Apache-2.0.
>>>
>>> This Jsoneditor provides different modes to view/edit json data. PFA
>>> attached SS.
>>>
>>
>> Nice!
>>
>>
>>> Should pgAdmin support all of these modes?
>>>
>>
>> I think so.
>>
>>
>>>
>>> Also the editor supports transformation of existing data using ordering
>>> & query language.PFA attached SS.
>>> Should pgAdmin also provide data transformation option?
>>>
>>
>> It's there, so yes.
>>
>>
>>>
>>> Also while using Code mode, a hyperlink shown - 'powered by ace'.
>>> Can pgAdmin hide this text?
>>>
>>
>> Yes (via CSS overrides - I'd rather not customize or vendorise the
>> component). Having it there is not a requirement of the Apache 2.0 licence;
>> we comply with that and give due credit through other means (consistent
>> with other modules/libraries).
>>
>> It seems like you've done all the integration work, unless your
>> screenshots are mockups. I think the main thing I can see that clearly
>> needs to be done is styling. We need to make sure that it follows our
>> themes, from colours, to button design, and even syntax highlighting, to
>> ensure it looks like a native part of pgAdmin.
>>
>>
>>
>>>
>>> [image: Screenshot 2021-07-15 at 5.19.30 PM.png]
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Database Infrastructure
>> Blog: https://www.enterprisedb.com/dave-page
>> Twitter: @pgsnake
>>
>> EDB: https://www.enterprisedb.com
>>
>

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"