From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4768] Reverse proxy on non-standard port |
Date: | 2019-10-01 06:33:52 |
Message-ID: | CAM9w-_mRhcST+8mAmRaiWOYbRD9B4SmA2xv5gPBooAR=n+ACXA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
I have added a backward compatible code in cases werkzeug is older. This
will never happen considering we use Flask 1.0.2.
Attached is the precautionary patch.
On Fri, Sep 27, 2019 at 1:29 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Thanks, patch applied.
>
> On Fri, Sep 27, 2019 at 12:17 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to allow pgAdmin to run behind reverse proxy on a
>> non standard port.
>> The middleware -
>> https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#werkzeug.middleware.proxy_fix.ProxyFix
>> allows us to set the number of trusted ports (and few other params) behind
>> the proxy. By default it is zero.
>> With this patch, user can set these params using pgAdmin config.
>> I have set the default value for port as 1, which will allow to run
>> behind non-standard port.
>>
>> I have added the documentation under reverse proxy section.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
RM4768.oldwerkzeug.patch | application/octet-stream | 467 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2019-10-01 06:55:15 | Re: [pgAdmin][RM4701] Webpack optimization |
Previous Message | Khushboo Vashi | 2019-09-30 12:36:19 | Re: [pgAdmin][RM4701] Webpack optimization |