From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility) |
Date: | 2019-05-22 05:52:31 |
Message-ID: | CAM9w-_mLi-NzgBBH1gbve4Xqg6-gjOLpVvh_zkMzfqai=se-pw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
Attached is the updated patch with doc changes.
On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> On Tue, May 21, 2019 at 5:32 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix the accessibility issue in query tool.
>>>
>>> The query tool can be completely restructured unlike previously where
>>> query tool used to stick at top and other tabs in the bottom.
>>> - I have added a new shortcut to switch between frames if in query tool
>>> the tab positions are changed. On switching the frames, the frame will
>>> blink to show it is focussed.
>>> - In the frame, you can switch tab same as previous. The tabs in SQL
>>> editor are cyclic now, which means if you execute shortcut to go right on
>>> the last tab then it will cycle to first tab.
>>> - I have also changed the default shortcut to switch between tabs from
>>> Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we have in
>>> browser tabs.
>>> - Similar changes done for debugger also.
>>>
>>
>> Shouldn't there be documentation changes to go with this?
>>
> Yes, definitely :P
> Will send the updated patch.
>
>>
>> Otherwise, it seems to work :-)
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
RM4195_v2.patch | application/octet-stream | 22.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Beighley, Thomas | 2019-05-22 16:48:58 | Bug Report - File uploads into wrong directory |
Previous Message | Aditya Toshniwal | 2019-05-22 05:11:53 | [pgAdmin][RM4263] "Not connected to the server or the connection to the server has been closed." returned with some queries |