Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property
Date: 2020-04-24 09:25:36
Message-ID: CAM9w-_mJx38RHr_bWedTnXMhn9RkH5SRGkcE8_2vPjCpgwrn3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix:
1. For synonyms, the property is shown as "Public Synonym".
2. For system procedure, the flag should be True but it is displaying as
False.
3. For both views and materialized views, the property is "System View".
4. For FTS templates, the property is showing as "System FTS Parser".

Please review.

On Thu, Apr 23, 2020 at 5:33 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied.
>
> On Thu, Apr 23, 2020 at 5:04 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to add the "System XXX?" property to the object
>> types where it was missing.
>> I've also attached a allobjects.sql file to create all types of objects
>> under a database for PGv12 which might help to test.
>> Please review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM1257.fixes.patch application/octet-stream 7.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2020-04-24 09:29:29 pgAgent commit: Fix a minor bug in pga_next_schedule, and bump the vers
Previous Message Vik Fearing 2020-04-24 09:23:27 Re: [pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version