[pgAdmin4][RM3575] Right click does not work on database node if server name changed

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][RM3575] Right click does not work on database node if server name changed
Date: 2019-01-09 10:46:03
Message-ID: CAM9w-_mBN5ZYxTZ2wcWuJ6RLvsffG+iha9Zb8bRJok=-cuNZ7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix the issue where changing the name (or any
visible property on tree) of the server node breaks the context menu on the
database nodes.

The user information of the server is updated on successful connection.
Here, the data is updated on the aciTreeNode(domNode). But, in the context
menu the user data is referred from TreeNode object (a wrapper to
aciTreeNode). After checking the code (and a lot of debugging) it was found
that aciTreeNode and TreeNode point to two different data(I don't know
why). Every time you change one, it should be synced to other, which is not
done everywhere.
Changes are done to point both aciTreeNode and TreeNode data to the same
data object.

Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Attachment Content-Type Size
RM3575.patch application/octet-stream 431 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-01-09 13:00:59 [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help
Previous Message Akshay Joshi 2019-01-09 10:38:44 [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab