Re: Require suggestions on feature 6794

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Pravesh Sharma <pravesh(dot)sharma(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: Require suggestions on feature 6794
Date: 2024-11-26 11:29:47
Message-ID: CAM9w-_kvjS_g1ZX5So=zMo-eJ=8H4_Ws=mfDEcDR92ftG4V3UA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Pravesh,

In addition to that, why do we need env vars at all? We can simply pass
them as arguments to passexec script. It's up to the users to use it or
ignore it.

On Tue, Nov 26, 2024 at 4:54 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Tue, 26 Nov 2024 at 10:55, Pravesh Sharma <
> pravesh(dot)sharma(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave/Team
>>
>> I have started working on feature #6794
>> <https://github.com/pgadmin-org/pgadmin4/issues/6794>. The user wants to
>> pass connection information, such as host, port, and username, to the
>> passexec command without hardcoding these values. I plan to implement it as
>> follows: The user will set environment variables for the host, port, and
>> username, and before running the passexec command, we will replace the
>> corresponding values with the environment variables.
>>
>>
>> Please share your suggestions or feedback on the approach I am proposing.
>>
>
> I'm not sure why the user would need to set environment variables -
> wouldn't pgAdmin just set them in the environment of the passexec
> process, based on the server definition?
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/>
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2024-11-26 11:33:56 Re: Require suggestions on feature 6794
Previous Message Dave Page 2024-11-26 11:24:09 Re: Require suggestions on feature 6794