[pgAdmin][RM5115] RULE SQL incorrectly generated

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][RM5115] RULE SQL incorrectly generated
Date: 2020-02-21 09:39:25
Message-ID: CAM9w-_koBKxTmVrO-LVOW7tgJE-o9dJtssQh5f5TtKYqS1g_sg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix the SQL parsing issue in rules. The command
and statements were parsed incorrectly.
Also fixed issue where removing command or statements altogether was not
generating modified SQL and so was not saving.
Test cases added and changed accordingly.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM5115.patch application/octet-stream 22.4 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Peter J. Holzer 2020-02-23 10:19:28 Re: DB running out of memory issues after upgrade
Previous Message Akshay Joshi 2020-02-21 07:45:38 Re: [pgAdmin][RM5133] UI Improvements for White and Dark Theme