Re: WIP: SQL Formatter

Hi,

On Fri, Jul 31, 2020 at 6:03 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> Currently, all the CodeMirrors in pgAdmin use the settings from the Query
>> tool -> Editor, even though they're not related. I think you're right.
>> We should move all CodeMirror settings out of the Query tool and move it to
>> a new node - "SQL" may be. Editor and Auto-format would be sub nodes under
>> SQL. With that, the editor settings will apply at all the places where
>> CodeMirror editing is used(function body, query tool). What do you say ?
>>
>
> Turns out that's more work than I really have time for at the moment,
> because it means making the editors be able to handle automatic reloads of
> multiple preference sections. We can always think about moving the
> formatting preferences into their own section later.
>
> In the meantime, this update to the patch does what was originally
> suggested and puts the options into a Query Tool -> SQL Formatting section.
>
Cool.

>
> Comments? Obviously docs will need updating too, once we're all happy with
> the basics.
>
It works nice. A shortcut and auto format only selected text would be
helpful.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"