Re: [pgAdmin][RM5227] Cannot add user

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][RM5227] Cannot add user
Date: 2020-04-10 10:40:48
Message-ID: CAM9w-_kPc2xPMwb_6hrg1RtN-Kv1MxUm=z3tEyFTGQbaM4wk0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the updated rebased patch.

On Fri, Apr 10, 2020 at 3:13 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya
>
> Can you please rebase and send the patch again.
>
> On Fri, Apr 10, 2020 at 10:33 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix following user management related issues:
>> 1) Unable to add a user when there are many users. The dialog went blank.
>> Fixed.
>> 2) Error message did not have a close button. Fixed.
>> 3) When clicked on the add button, then cursor will focus on the email
>> box of the new row for convenience.
>> 4) When the dialog opens, the cursor will focus on the search text box.
>> 5) By default, "User" role will be selected when adding a new user. Also
>> removed an empty option in the roles dropdown.
>> 6) When the search filter is applied and we try to add an already
>> existing user, the validation is done only on the filtered data and not on
>> all the users data. This is fixed.
>>
>> Please review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM5227_v2.patch application/octet-stream 10.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-04-10 12:06:06 pgAdmin 4 commit: Fixes following OSX native keyboard shortcuts in Quer
Previous Message Murtuza Zabuawala 2020-04-10 10:30:00 Re: [pgAdmin4][RM#2813] Do not prompt for database server password once user saves it