Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures
Date: 2018-08-27 14:02:38
Message-ID: CAM9w-_kJVrZP=0ovWQZ=+DjOOYCET3_zHFmkq9XkbkjqJk4t5w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the updated patch which also includes code changes to avoid
reloading same proc/function again in case of a recursive call.

On Mon, Aug 27, 2018 at 6:44 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Please hold on with the patch. As discussed and found by Ashesh Vashi, if
> we <Step In> the function called recursively then it is loading the
> debugger with source code again which can be avoided and will improve
> performance if the function is large.
> Will send the updated patch along with the required changes. Thank you
> Ashesh.
>
> On Mon, Aug 27, 2018 at 6:16 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to make debugger scroll automatically to current
>> active line and scroll along with StepIn/StepOut. Previously, we had to
>> manually scroll.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Attachment Content-Type Size
RM3554.patch application/octet-stream 8.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2018-08-28 05:52:20 Re: [pgAdmin4][RM#3590] Fix refresh button on Dashboard
Previous Message Akshay Joshi 2018-08-27 13:41:32 pgAdmin 4 commit: Ensure external table node should be visible only for