[pgAdmin4][RM4037] COMMENTS from inherited fields are not present when seeing generated SQL from a table

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][RM4037] COMMENTS from inherited fields are not present when seeing generated SQL from a table
Date: 2019-03-27 12:55:42
Message-ID: CAM9w-_k7cjovXcVtJkiHTdh+60C-eYOSGZ_1sNqQ22q=6QnjSA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch which fixes the issue where comments added in child
table on inherited columns where not showing in reverse engineered SQL.

I have also made changes to show column details of inherited columns of
table, as well as for "of type" tables similar to pgAdmin3. eg-
CREATE TABLE public.inhactortest
(
-- Inherited from table public.actor: actor_id integer NOT NULL DEFAULT
nextval('actor_actor_id_seq'::regclass),
-- Inherited from table public.actor: first_name character varying(45)
COLLATE pg_catalog."default" NOT NULL,
-- Inherited from table public.actor: last_name character varying(45)
COLLATE pg_catalog."default" NOT NULL,
-- Inherited from table public.test_table: col1 integer,
-- Inherited from table public.test_table: col2 "char",
-- Inherited from table public.test_table: col3 character varying COLLATE
pg_catalog."default",
owncol integer
)
INHERITS (public.actor, public.test_table)
WITH (
OIDS = FALSE
)
TABLESPACE pg_default;

ALTER TABLE public.inhactortest
OWNER to postgres;

COMMENT ON COLUMN public.inhactortest.actor_id
IS 'in child c';
--

Kindly review.

Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Attachment Content-Type Size
RM4037.patch application/octet-stream 7.7 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-03-28 05:59:53 Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not present when seeing generated SQL from a table
Previous Message Aditya Toshniwal 2019-03-27 07:02:25 [pgAdmin4][RM4105] select for json context doesn't work