Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure

Hi Khushboo,

I suggest,
1) Remove the commented code

+ # if 'mail' in entry:

+ # user_email = entry['mail'].value
2) Change the below condition to check "is not None" instead which makes
more sense.

+ if not self.bind_user or not self.bind_pass:

Other changes looks fine.

On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya,
>
> Can you please review it.
>
> On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch for the RM 5484 - Support LDAP based auth
>> also when users do not have the same DN structure.
>>
>> Currently, pgAdmin only supports LDAP authentication with the same DN
>> structure. With this patch, the LDAP authentication will also support the
>> different DN by setting the dedicated user for the LDAP connection in the
>> config file.
>>
>> Thanks,
>> Khushboo
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"