Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Thu, Nov 7, 2019 at 2:18 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the updated patch with few more changes and corrections.
>>>> Kindly review.
>>>>
>>>
>> I've committed a couple of minor tweaks - one to remove a space, e.g.
>>
>> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
>>
>> is now:
>>
>> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
>>
>> And another change to fix the word wrapping in the README which was
>> totally different from the rest of the file.
>>
>> Thanks!
>>
>
> Oh, and do we need all the code in config.py? I really didn't even want a
> config option in there to turn theming on or off (what's the point?), let
> alone 20 new lines.
>
The code is added after the config_local and config_distro is loaded. So,
user won't be able to disable it unless he directly changes the config.py.
I'll reduce the code a bit.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"