Re: [pgAdmin][RM5398] Bad display of tables storage parameters in the "SQL" tab

Hi Akshay,

On Wed, May 6, 2020 at 2:43 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya
>
> RESQL test cases are failing for all database server and one minor issue I
> found:
>

> - open the properties dialog for any existing table and set the
> "Custom auto-vacuum?" to Yes.
> - Save button gets enabled and when clicking on it we get "can't
> execute an empty query" error.
>
> I'm aware of the behaviour. Custom auto-vacuum do not affect SQL
directly. Once you change the switch there is a change in the model, which
enables the Save button. Along with custom auto-vacuum there are has to be
some other option. So there is a change in model which does not change SQL.
What solution do you suggest ?

>
> Please fix the above and send the patch again.
>
> On Tue, May 5, 2020 at 12:07 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to:
>> 1) Fix the SQL generated for autovacuum options. It was not displaying
>> the vacuum options until autovacuum_enabled is set to true. Vacuum options
>> setting does not depend on autovacuum_enabled, and this was being wrongly
>> interpreted by pgAdmin.
>> 2) pgAdmin allows only true or false values for autovacuum_enabled, and
>> there is no way to reset it individually without disabling custom
>> autovacuum. To fix this, the control is changed from switch to three state
>> buttons. Screenshot below:
>> [image: Screenshot 2020-05-05 at 11.44.11 AM.png]
>> 3) Setting any vacuum options to zero made the option disappear from the
>> SQL.
>> 4) Right click on a table with vacuum options set and create a new table.
>> The parameters tab will have the options prefilled. This is fixed.
>> 5) Changed the UI a bit to remove unnecessary space around.
>> Added "Autovacuum" before enabled.
>> 6) The SQL generated was appending a ".0" to decimal vacuum options.
>> Changed to remove the leading ".0".
>> 7) Test cases updated to increase the scenarios.
>> 8) Documentation update.
>>
>> Please review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"