[pgAdmin][RM5398] Bad display of tables storage parameters in the "SQL" tab

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][RM5398] Bad display of tables storage parameters in the "SQL" tab
Date: 2020-05-05 06:36:25
Message-ID: CAM9w-_=Pd10HgM4GKtzFFweLx12rmubwPgjoUxQqJL2ERkuVoA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to:
1) Fix the SQL generated for autovacuum options. It was not displaying the
vacuum options until autovacuum_enabled is set to true. Vacuum options
setting does not depend on autovacuum_enabled, and this was being wrongly
interpreted by pgAdmin.
2) pgAdmin allows only true or false values for autovacuum_enabled, and
there is no way to reset it individually without disabling custom
autovacuum. To fix this, the control is changed from switch to three state
buttons. Screenshot below:
[image: Screenshot 2020-05-05 at 11.44.11 AM.png]
3) Setting any vacuum options to zero made the option disappear from the
SQL.
4) Right click on a table with vacuum options set and create a new table.
The parameters tab will have the options prefilled. This is fixed.
5) Changed the UI a bit to remove unnecessary space around.
Added "Autovacuum" before enabled.
6) The SQL generated was appending a ".0" to decimal vacuum options.
Changed to remove the leading ".0".
7) Test cases updated to increase the scenarios.
8) Documentation update.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM5398v1.patch application/octet-stream 345.5 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Mishika Singh 2020-05-05 07:02:40 Error while connecting server on pgAdmin4 (KeyError: 'version')
Previous Message Dave Page 2020-05-04 14:36:17 Re: Patch to remove Python 2.7 support in the macOS Appbundle