From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][SonarQube] Replace the generic exception class with a more specific one |
Date: | 2020-08-07 06:06:16 |
Message-ID: | CAM9w-_=66e84my5FvSvxLJn8sATQ53vVWR=MLSwzbV-wGd50Mg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
Attached is the followup patch to fix all the remaining issues (around 30)
related to replacing the generic exception class with more specific ones.
Please review.
On Wed, Aug 5, 2020 at 12:42 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Thanks, patch applied.
>
> On Wed, Aug 5, 2020 at 11:09 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to replace the generic exception class with a newly
>> added ExecuteError class for all the places where error occurs when a SQL
>> is executed.
>> This fixes around 34 issues.
>>
>> Please review.
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
sonarqube.exception.patch | application/octet-stream | 17.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Nikhil Mohite | 2020-08-07 06:20:51 | [pgAdmin][RM5713]:Incorrect DROP SQL for Catalog and Foreign Server |
Previous Message | Pramod Ahire | 2020-08-07 05:08:57 | Re: Code coverage report generation for JS files |