Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

Hi Akshay,

I tried to simulate, but no luck. It works on my system :(

On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya
>
> I have applied your patch but following test cases are failing
> consistently:
>
> - CopySelectedQueryResultsFeatureTest
> - QueryToolAutoCompleteFeatureTest
>
> I have verified your patch on Mac OSX and Ubuntu. Chrome Version
> 71.0.3578.98
>
> On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Tue, 29 Jan 2019, 19:09 Dave Page <dpage(at)pgadmin(dot)org wrote:
>>
>>> Akshay, can you look at this please?
>>>
>>
>> Sure.
>>
>>>
>>> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
>>> <aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>> >
>>> > Hi Hackers,
>>> >
>>> > Attached is the updated patch. I have changed fill_input_by_field_name
>>> function to use javascript to set values of text boxes and the selector is
>>> changed from xpath to CSS with a :not(:disabled) clause. With this, test
>>> case will fail if tried to set the value of a disabled input.
>>> >
>>> > Kindly review.
>>> >
>>> >
>>> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>> >>
>>> >>
>>> >>
>>> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>> >>>
>>> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
>>> >>> <aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>> >>> >
>>> >>> > Hi Dave,
>>> >>> >
>>> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page <dpage(at)pgadmin(dot)org>
>>> wrote:
>>> >>> >>
>>> >>> >> Hi
>>> >>> >>
>>> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
>>> >>> >> <aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>> >>> >> >
>>> >>> >> > Hi Hackers,
>>> >>> >> >
>>> >>> >> > Attached is the patch to fix failing SQL editor related feature
>>> tests.
>>> >>> >> > The failure is occurring mostly because of send_keys function
>>> of selenium which sometimes does not input the complete text. The change
>>> will use Codemirror javascript object to set the text.
>>> >>> >> >
>>> >>> >> > I have also added new args flag "--modules" which can be used
>>> after --pkg where you can test a specific module file under the pkg. This
>>> is not so useful for build but definitely helpful for the developers.
>>> >>> >>
>>> >>> >> One of the most common failures I see is failure to fill in the
>>> >>> >> details on the Add Server dialogue (it might type half of an
>>> entry,
>>> >>> >> then just hang). Should we get rid of all uses of send_keys?
>>> >>> >
>>> >>> > Setting the text using javascript executor can be done. send_keys
>>> simulate an actual person, so if you try to set a disabled text box using
>>> send_keys, it won't. Places where disabled fields doesn't matter, send_keys
>>> can be removed.
>>> >>>
>>> >>> Can't we just do something like:
>>> >>>
>>> >>> if input.disabled == false:
>>> >>> input.value = 'Foo';
>>> >>> else:
>>> >>> raise exception ....
>>> >>
>>> >> I'll check if this can be done. Will get back.
>>> >>>
>>> >>>
>>> >>> --
>>> >>> Dave Page
>>> >>> Blog: http://pgsnake.blogspot.com
>>> >>> Twitter: @pgsnake
>>> >>>
>>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>>> >>> The Enterprise PostgreSQL Company
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Thanks and Regards,
>>> >> Aditya Toshniwal
>>> >> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> >> "Don't Complain about Heat, Plant a tree"
>>> >
>>> >
>>> >
>>> > --
>>> > Thanks and Regards,
>>> > Aditya Toshniwal
>>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>> > "Don't Complain about Heat, Plant a tree"
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"