Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

Hi Pradip,

The patch looks good to me.

On Mon, Apr 27, 2020 at 6:23 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Please ignore my previous patch. Please find the latest patch.
>
> On Mon, Apr 27, 2020 at 5:53 PM Pradip Parkale <
> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>
>> Hi Akshay/Aditya,
>>
>> Please find the updated patch. I fixed the regression where initial changes
>> were making the save button enabled when a table dialog is opened.
>> Also removed 'like' options from the dialog while editing table
>> properties as there is no point in showing those to the user as those
>> options are not editable once the table is created.
>>
>> Please review.
>>
>>
>> On Fri, Apr 24, 2020 at 6:29 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Fri, Apr 24, 2020 at 5:42 PM Pradip Parkale <
>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Navnath,
>>>>
>>>> Please find the updated patch.
>>>>
>>>> On Fri, Apr 24, 2020 at 4:29 PM navnath gadakh <
>>>> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Pradip,
>>>>> Patch looks good to me except one minor issue -
>>>>> Create a table without selecting any relation then try to update table
>>>>> like options switch buttons are still enabled.
>>>>>
>>>> Fixed.
>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Apr 24, 2020 at 3:04 PM navnath gadakh <
>>>>> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>> I will be reviewing this RM.
>>>>>>
>>>>>> On Fri, Apr 24, 2020 at 1:48 PM Pradip Parkale <
>>>>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi Hackers,
>>>>>>>
>>>>>>> Attached is a patch to make like options disable if Relation is not
>>>>>>> selected while creating a table.
>>>>>>>
>>>>>>> Please review.
>>>>>>>
>>>>>>> --
>>>>>>> Thanks & Regards,
>>>>>>> Pradip Parkale
>>>>>>> QMG, EnterpriseDB Corporation
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Navnath Gadakh
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Navnath Gadakh
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> QMG, EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> QMG, EnterpriseDB Corporation
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"