| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4] Update require.js library to latest version |
| Date: | 2021-05-04 11:59:52 |
| Message-ID: | CAM9w-_==t+j+peJ+UmpdbCS_pG9eOFbHXr8jeKdgHAUVD3X0Mw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Akshay,
Since we're using it from the vendor directory, please yarn remove requirejs to
remove it from the package.json file.
Other than that, the patch looks good to me.
On Tue, May 4, 2021 at 5:08 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Aditya,
>
> Can you please review it?
>
> On Tue, May 4, 2021 at 2:07 PM Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA patch to update the require.js library to the latest version.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2021-05-04 12:18:20 | pgAdmin 4 commit: Update require.js library to the latest version. |
| Previous Message | Akshay Joshi | 2021-05-04 11:38:13 | Re: [pgAdmin4] Update require.js library to latest version |