| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Fixes #1986 - Properly handle non-ascii characters while loading & saving file |
| Date: | 2016-11-24 10:11:24 |
| Message-ID: | CAM5-9D_vE2BdhkRxGH_M-KMnLhveUaUCFje0CrSs_XQ9AaEyBw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Please ignore above patch. because it breaks when we save a file with name
containing ascii chars in py35
It is fixed. Please find attached patch and review.
On Thu, Nov 24, 2016 at 2:56 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> *Issue:*
> The content will not write to disk if it contains ascii characters.
>
> *Solution:*
> Encode/Decode the content before writing/reading the file.
>
> By the way, the file/folder name should also encode/decode, a similar
> issue is already logged
> #1940 <https://redmine.postgresql.org/issues/1940>. I will work on it.
>
> Please find attached path and review.
>
>
> Thanks,
> Surinder Kumar
>
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM1986_v2.patch | application/octet-stream | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Harshal Dhumal | 2016-11-24 10:25:42 | Re: Patch for RM1911 Direct file navigation [pgAdmin4] [Feature] |
| Previous Message | Murtuza Zabuawala | 2016-11-24 09:59:37 | PATCH: To fix issue in database node (pgAdmin4) |